-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Filter Component Structure #165
base: NEW-UI
Are you sure you want to change the base?
Changed Filter Component Structure #165
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @stephin007 on Vercel. @stephin007 first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/stephin007/cowin-vaccine-availablity-checker/9ihxw7HA2f9f996pzgT61may4EVQ |
@himanshujasuja1040 This has some issues,
Will add more if i find more issues. |
@Justinnn07 can you do the code review to find if there is any issue with it or if there are any redundant parts. |
Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@himanshujasuja1040 Efforts appreciated!
- When there is no data of the current filter .. please show the null state component
- please align the btns of the filter
Check the comments, which @stephin007 mentioned earlier ..
Rest changes looks good to me!
Also, Please fill the PR template too! 😂
Thanks
Please check if the PR fulfills these requirements
Describe your changes
What kind of change does this PR introduce? (Filter Component Structure Changed)
What is the current behavior? (Multiple Filter Option Select at one time)
What is the new behavior (if this is a feature change)?(User Can Only Select One Filter Type only)
Does this PR introduce a breaking change? (i.e changes that may require users to update/refactor existing istances of the application)
Other Information:
❤️ Thank you!