Prepend 'XF86' where needed for audio/backlight #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking in the 'Key' region for a binding it prompts you to enter a new accelerator, entering any dedicated key for audio or backlight will give you `AudioRaiseVolume`, `MonBrightness`, so on and so forth. If you have dedicated volume or backlight keys then the bound keys need to be `XF86AudioRaiseVolume`, `XF86AudioLowerVolume`, `XF86MonBrightnessUp`, `XF86MonBrightnessDown`, etc.. Please correct me if I am wrong. The key is returned by `key_gtk2openbox()`, this patch simply prepends `XF86` when the key name has 'Audio' or 'MonBrightness' in it. I'm sure there could be a more fancy way of doing this however this works and I don't believe it will have any collisions with other mappings/keys. Cheers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking in the 'Key' region for a binding it prompts you to enter a new accelerator, entering any dedicated key for audio or backlight will give you
AudioRaiseVolume,MonBrightnessUp, so on and so forth. If you have dedicated volume or backlight keys then the bound keys need to beXF86AudioRaiseVolume,XF86AudioLowerVolume,XF86MonBrightnessUp,XF86MonBrightnessDown, etc..Please correct me if I am wrong.
The key is returned by
key_gtk2openbox(), this patch simply prependsXF86when the key name has 'Audio' or 'MonBrightness' in it.I'm sure there could be a more fancy/robust way of doing this (dict, etc), however this works and I don't believe it will have any collisions with other mappings/keys.
Cheers