Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show errors and check exit code for wheel filename formatting #960

Merged

Conversation

christian-rauch
Copy link
Collaborator

@christian-rauch christian-rauch commented Oct 30, 2024

Even with setuptools installed, the bdist_wheel snippet could still silently fail with an empty wheel filename. Fix this by showing the error and checking the exit code. Also, test for bdist_wheel and inform the user.

Fixes #959.

@christian-rauch christian-rauch marked this pull request as ready for review October 30, 2024 22:25
@christian-rauch christian-rauch merged commit ad60315 into stevenlovegrove:master Nov 1, 2024
14 checks passed
@christian-rauch christian-rauch deleted the improve_python_checks branch November 1, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid .whl name compiling inside a python virtual (venv) environment
2 participants