Skip to content
This repository was archived by the owner on Jul 3, 2023. It is now read-only.

Commit

Permalink
Tweaks warning message from pandas index check
Browse files Browse the repository at this point in the history
If using a dask dataframe or series the index type checker
will not capture it because it only checks for pandas types.
So adding note to ignore if using DASK.

We will have to figure out how to support this -- likely
with a specific result builder for Dask that takes this into
account, or something like that.
  • Loading branch information
skrawcz committed Oct 21, 2022
1 parent 81798ea commit 646c518
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion hamilton/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ def check_pandas_index_types_match(
logger.warning(
"It appears no Pandas index type was detected. This will likely break when trying to "
"create a DataFrame. E.g. are you requesting all scalar values? Use a different result "
"builder or return at least one Pandas object with an index."
"builder or return at least one Pandas object with an index. "
"Ignore this warning if you're using DASK for now."
)
types_match = False
if logger.isEnabledFor(logging.DEBUG):
Expand Down

0 comments on commit 646c518

Please sign in to comment.