Prefer 'Regexp#match?' over 'Regexp#=~' when the result is not needed (…

…#98) '=~' allocates a MatchData, 'match?' does not
stitchfix · Feb 11, 2021 · 6d5fe27 · 6d5fe27
1 parent e26d45e
commit 6d5fe27
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/stitches/valid_mime_type.rb b/lib/stitches/valid_mime_type.rb
@@ -20,7 +20,7 @@ class ValidMimeType < Stitches::AllowlistMiddleware
 
     def do_call(env)
       accept = String(env["HTTP_ACCEPT"])
-      if (accept =~ %r{application/json} && accept =~ %r{version=\d+}) || accept =~ %r{application/protobuf}
+      if (%r{application/json}.match?(accept) && %r{version=\d+}.match?(accept)) || %r{application/protobuf}.match?(accept)
         @app.call(env)
       else
         not_acceptable_response(accept)