Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: whitespace stripping #3

Merged
merged 6 commits into from
Sep 5, 2024
Merged

feat: whitespace stripping #3

merged 6 commits into from
Sep 5, 2024

Conversation

a-frantz
Copy link
Collaborator

@a-frantz a-frantz commented Sep 5, 2024

We probably could've achieved our goals here without this, but now when we convert WDL to Bash scripts it will have pretty whitespace 😃

Relevant WDL docs: https://github.com/openwdl/wdl/blob/wdl-1.2/SPEC.md#multi-line-strings and https://github.com/openwdl/wdl/blob/wdl-1.2/SPEC.md#command-section

@a-frantz a-frantz self-assigned this Sep 5, 2024
Copy link
Collaborator

@claymcleod claymcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for this hackathon. You might consider using a Cow in the future here (when the String doesn't need to be modified, the original referenced &str can be returned without an allocation.

@claymcleod
Copy link
Collaborator

(Also needs the lint fixes)

@a-frantz a-frantz merged commit bd760ef into main Sep 5, 2024
6 checks passed
@a-frantz a-frantz deleted the feat/whitespace-stripping branch September 5, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants