Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show gain and loss in one color scale legend item #2423

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

creilly8
Copy link
Contributor

@creilly8 creilly8 commented Nov 22, 2024

Description

Closes issue #2374.

The cnv gain and loss legend item data is merged into one legend item in svg.legend. The goal was to recreate the cnv color scale in the mds3 track.

Changes:

  1. Increase code encapsulation for the color scale, code reorg
  2. Update svg.legend to combine gain and loss legend items into one a parents property
  3. Minor update to the disco code to support the merged gain and loss items
  4. Minor updates to the matrix interactivity code to act on parents of a legend item to maintain the functionality.

Test

  1. Disco example
  2. Matrix example

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@creilly8 creilly8 marked this pull request as ready for review November 22, 2024 22:28
@creilly8 creilly8 linked an issue Nov 22, 2024 that may be closed by this pull request
@xzhou82
Copy link
Collaborator

xzhou82 commented Nov 25, 2024

ash matrix cnv legend doesn't show properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matrix/svg.legend cnv legend refactor
2 participants