Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show violin plots with a sample size less than 5 #2893

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

creilly8
Copy link
Contributor

@creilly8 creilly8 commented Feb 27, 2025

Description

Closes issue #2618. Will show the item as uncomputable in the legend instead.

Test with this violin example. Should see four values as uncomputable because of sample size.

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@creilly8 creilly8 requested a review from airenzp February 27, 2025 21:29
@creilly8
Copy link
Contributor Author

@airenzp, quick question - Why is the legend set so uncomputable values only appear for the continuous term? In the example above the continuous term is term but all the plots are values of term2/overlayTerm. An uncomputable value would never show in this instance.

@creilly8 creilly8 marked this pull request as ready for review February 28, 2025 17:59
@creilly8 creilly8 requested a review from xzhou82 February 28, 2025 18:00
@xzhou82 xzhou82 marked this pull request as draft March 2, 2025 15:49
@xzhou82
Copy link
Collaborator

xzhou82 commented Mar 2, 2025

violin should work the same as boxplot.

in this example there are groups <=5 only showing dots but no boxplot; violin should do same to only show "bead plot" on client, and do not compute violin on server, and render violin on client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

violin should follow boxplot and not to compute a violin plot when group size is under 5
2 participants