-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STM32L5xx] Add support for STM32L562E-DK board #2696
base: main
Are you sure you want to change the base?
Conversation
Hold off on reviewing this, I found some issues I am fixing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
First feedback.
variants/STM32L5xx/L552Q(C-E)IxQ_L562QEIxQ/variant_STM32L562E_DK.cpp
Outdated
Show resolved
Hide resolved
variants/STM32L5xx/L552Q(C-E)IxQ_L562QEIxQ/variant_STM32L562E_DK.cpp
Outdated
Show resolved
Hide resolved
variants/STM32L5xx/L552Q(C-E)IxQ_L562QEIxQ/variant_STM32L562E_DK.cpp
Outdated
Show resolved
Hide resolved
variants/STM32L5xx/L552Q(C-E)IxQ_L562QEIxQ/variant_STM32L562E_DK.h
Outdated
Show resolved
Hide resolved
variants/STM32L5xx/L552Q(C-E)IxQ_L562QEIxQ/variant_STM32L562E_DK.h
Outdated
Show resolved
Hide resolved
OK @fpistm I think I'm ready for your re-review. Hopefully got all the changes you requested. Thanks |
Hi @haydenth and thanks. Seems not all were addressed but will review it and update if needed. |
OK thanks if i missed anything let me know. It's hard to keep track while also updating all the pin configurations :) |
Hi @haydenth /edit: 3D Accelrator and gyroscope also tested with https://github.com/stm32duino/LSM6DSO (using LSM6DSO_I2C_ADD_L and PF3 as INT pin). |
Signed-off-by: Tom Hayden <[email protected]> Co-Authored-by: Frederic Pillon <[email protected]>
Signed-off-by: Tom Hayden <[email protected]> Co-Authored-by: Frederic Pillon <[email protected]>
Amazing!! Thank you so much |
Adds support for the STM32L562E-DK Discovery Kit
Resolves #2694