Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.14] Update net and crypto pkgs #142

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

dhaiducek
Copy link

Copy link

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be go.sum changes, right? I'll come back to look at this after other reviews, I wonder if the CI isn't checking things are synchronized...

@dhaiducek
Copy link
Author

There should be go.sum changes, right? I'll come back to look at this after other reviews, I wonder if the CI isn't checking things are synchronized...

Good catch! There's a go mod verify in the CI, but I guess that doesn't check go.sum...

@JustinKuli
Copy link

Good catch! There's a go mod verify in the CI, but I guess that doesn't check go.sum...

Yeah, I think it needs go mod tidy and we need to remove the replace statements for net and crypto

@JustinKuli
Copy link

#148

@openshift-ci openshift-ci bot added the lgtm label Dec 20, 2024
Copy link

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 551e9ef into release-3.14 Dec 20, 2024
8 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the vuln-net-crypto-314 branch December 20, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants