Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.23.2 #1305

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Bump to 1.23.2 #1305

merged 1 commit into from
Dec 25, 2024

Conversation

clyang82
Copy link
Contributor

Summary

kessel-inventory api is using golang 1.23.1. we have to upgrade to 1.23 so that we can use the latest kessel inventory
And midstream is using openshift-golang-builder:v1.23.2 which should be fine for build.

Related issue(s)

Fixes #

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.

Signed-off-by: clyang82 <[email protected]>
@ldpliu
Copy link
Contributor

ldpliu commented Dec 25, 2024

/lgtm

Copy link

openshift-ci bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, ldpliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ldpliu ldpliu merged commit 35505dd into stolostron:main Dec 25, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants