Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove resource limit #1310

Merged
merged 1 commit into from
Jan 6, 2025
Merged

remove resource limit #1310

merged 1 commit into from
Jan 6, 2025

Conversation

ldpliu
Copy link
Contributor

@ldpliu ldpliu commented Jan 3, 2025

Summary

Related issue(s)

https://issues.redhat.com/browse/ACM-16349
Fixes #

Tests

  • Unit/function tests have been added and incorporated into make unit-tests.
  • Integration tests have been added and incorporated into make integration-test.
  • E2E tests have been added and incorporated into make e2e-test-all.
  • List other manual tests you have done.

@ldpliu ldpliu force-pushed the remove-limit branch 3 times, most recently from 9d8fd9b to 0b11bd8 Compare January 3, 2025 10:29
@clyang82
Copy link
Contributor

clyang82 commented Jan 6, 2025

/retest

@clyang82
Copy link
Contributor

clyang82 commented Jan 6, 2025

This is a breaking change. We need to update the document to say after upgrade to this new version, the resource limits do not take effect.

Copy link
Contributor

@clyang82 clyang82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clyang82, ldpliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 6, 2025
@clyang82 clyang82 merged commit e7fd594 into stolostron:main Jan 6, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants