-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Install GH into a brownfield #1319
Conversation
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
@@ -107,6 +107,13 @@ type MulticlusterGlobalHubSpec struct { | |||
// +operator-sdk:csv:customresourcedefinitions:type=spec,xDescriptors={"urn:alm:descriptor:com.tectonic.ui:booleanSwitch"} | |||
// +optional | |||
EnableMetrics bool `json:"enableMetrics"` | |||
// InstallAgentOnHub determines whether deploy the Global Hub Agent on hub cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the global hub involves different hubs - global hub, managed hub.
- "on hub cluster" -> "on global hub cluster"?
- "on hub cluster" -> "on local hub cluster"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to InstallAgentOnLocal
// InstallAgentOnHub determines whether deploy the Global Hub Agent on hub cluster. | ||
// If set to true, the Global Hub Agent will be installed on the hub cluster only. | ||
// If set to false, the Global Hub Agent will not be installed on the hub cluster. | ||
// Currently, switching the value of this field is not supported after the Global Hub is installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means that value should be set when creating the instance. After creating, it won't support being updated.
If so, we should clarify the value is immutable and add validation for this logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is no validation here, the desired and actual status will not be consistent after the user updates it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just an initial version. Based on my understanding, we do not support switching the value right now. but we may support later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, Could you log a Jira issue(or GitHub issue), I'm concerned we might overlook it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1321 log this github issue to trace. Thanks.
Signed-off-by: clyang82 <[email protected]>
Quality Gate passedIssues Measures |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clyang82, yanmxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
InstallAgentOnHub determines whether deploy the Global Hub Agent on hub cluster.
If set to true, the Global Hub Agent will be installed on the hub cluster only.
If set to false, the Global Hub Agent will not be installed on the hub cluster.
Currently, switching the value of this field is not supported after the Global Hub is installed.
Related issue(s)
Fixes # https://issues.redhat.com/browse/ACM-15099
Tests
make unit-tests
.make integration-test
.make e2e-test-all
.