make sure local cluster is part of list all the time

Signed-off-by: Coleen Iona Quadros <[email protected]>

operators/multiclusterobservability/controllers/placementrule/placementrule_controller.go

@@ -127,9 +127,21 @@ func (r *PlacementRuleReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	// We want to ensure that the local-cluster is always in the managedClusterList
 	// In the case when hubSelfManagement is enabled, we will delete it from the list and modify the object
 	// to cater to the use case of deploying in open-cluster-management-observability namespace
-	if req.Name == "local-cluster" {
+	delete(managedClusterList, "local-cluster")
+	if _, ok := managedClusterList["local-cluster"]; !ok {
+		obj := &clusterv1.ManagedCluster{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "local-cluster",
+				Namespace: config.GetDefaultNamespace(),
+				Labels: map[string]string{
+					"openshiftVersion": "mimical",
+				},
+			},
+		}
 		installMetricsWithoutAddon = true
+		updateManagedClusterList(obj)
 	}
+
 	if !deleteAll && !mco.Spec.ObservabilityAddonSpec.EnableMetrics {
 		reqLogger.Info("EnableMetrics is set to false. Delete Observability addons")
 		deleteAll = true

operators/multiclusterobservability/controllers/placementrule/predicate_func.go

@@ -6,6 +6,7 @@ package placementrule
 
 import (
 	"fmt"
+	clusterv1 "open-cluster-management.io/api/cluster/v1"
 	"reflect"
 	"strings"
 
@@ -61,6 +62,11 @@ func getClusterPreds() predicate.Funcs {
 			}
 			updateManagedClusterList(e.ObjectNew)
 		}
+		//log the diff in managedccluster object
+		if !reflect.DeepEqual(e.ObjectNew.(*clusterv1.ManagedCluster), e.ObjectOld.(*clusterv1.ManagedCluster)) {
+			log.Info("managedcluster object New diff", "managedCluster", e.ObjectNew.GetName(), "diff", fmt.Sprintf("%+v", e.ObjectNew.(*clusterv1.ManagedCluster)))
+			log.Info("managedcluster object Old diff", "managedCluster", e.ObjectOld.GetName(), "diff", fmt.Sprintf("%+v", e.ObjectOld.(*clusterv1.ManagedCluster)))
+		}
 
 		return true
 	}