Dashboard loader: use exit code 1 instead of 3

1 is slightly better than one, since 1 is usually used as a generic "the program had an error" exit code. Signed-off-by: Jacob Baungard Hansen <[email protected]>
stolostron · Oct 8, 2024 · a3e0b71 · a3e0b71
1 parent 8307911
commit a3e0b71
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/loaders/dashboards/pkg/controller/dashboard_controller.go b/loaders/dashboards/pkg/controller/dashboard_controller.go
@@ -119,7 +119,7 @@ func newKubeInformer(coreClient corev1client.CoreV1Interface) (cache.SharedIndex
 					break
 				} else if times == dashboardRetry {
 					klog.Errorf("dashboard: %s could not be created after retrying %v times", obj.(*corev1.ConfigMap).Name, dashboardRetry)
-					os.Exit(3)
+					os.Exit(1)
 				}
 
 				klog.Warningf("creation of dashboard: %v failed. Retrying in 10s. Error: %v", obj.(*corev1.ConfigMap).Name, err)
@@ -145,7 +145,7 @@ func newKubeInformer(coreClient corev1client.CoreV1Interface) (cache.SharedIndex
 					break
 				} else if times == dashboardRetry {
 					klog.Errorf("dashboard: %s could not be created after retrying %v times", new.(*corev1.ConfigMap).Name, dashboardRetry)
-					os.Exit(3)
+					os.Exit(1)
 				}
 
 				klog.Warningf("updating of dashboard: %v failed. Retrying in 10s. Error: %v", new.(*corev1.ConfigMap).Name, err)