Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-8232] call addonMgr.start asynchronously #1263

Closed
wants to merge 1 commit into from
+9 −5
Closed

[ACM-8232] call addonMgr.start asynchronously #1263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions operators/multiclusterobservability/pkg/certificates/cert_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,15 @@ func Start(c client.Client, ingressCtlCrdExists bool) {
os.Exit(1)
}

err = addonMgr.Start(context.TODO())
if err != nil {
log.Error(err, "Failed to start addon manager")
os.Exit(1)
}
go func() {
ctx := context.TODO()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs some centralized context, in the future

err = addonMgr.Start(ctx)
if err != nil {
log.Error(err, "Failed to start addon manager")
os.Exit(1)
}
<-ctx.Done()
}()

kubeClient, err := kubernetes.NewForConfig(ctrl.GetConfigOrDie())
if err != nil {
Expand Down
Loading