[ACM-3748] Set max source resolution to auto in Grafana datasource #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Camata <[email protected]>
douglascamata
force-pushed
the
ACM-3748/set-max-source-resolution-auto
branch
from
53cd700 to
f3c427f
Compare
Signed-off-by: Douglas Camata <[email protected]>
|
Tested this with a local cluster and it worked! 🎉 
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglascamata, subbarao-meduri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed!
|
subbarao-meduri
pushed a commit
to subbarao-meduri/multicluster-observability-operator
that referenced
this pull request
Oct 27, 2023
…tolostron#1264) * Set max source resolution to auto in Grafana datasource Signed-off-by: Douglas Camata <[email protected]> * Move custom query parameter into jsondata Signed-off-by: Douglas Camata <[email protected]> --------- Signed-off-by: Douglas Camata <[email protected]>
subbarao-meduri
pushed a commit
to subbarao-meduri/multicluster-observability-operator
that referenced
this pull request
Oct 27, 2023
…tolostron#1264) * Set max source resolution to auto in Grafana datasource Signed-off-by: Douglas Camata <[email protected]> * Move custom query parameter into jsondata Signed-off-by: Douglas Camata <[email protected]> --------- Signed-off-by: Douglas Camata <[email protected]>
subbarao-meduri
pushed a commit
to subbarao-meduri/multicluster-observability-operator
that referenced
this pull request
Oct 27, 2023
…tolostron#1264) * Set max source resolution to auto in Grafana datasource Signed-off-by: Douglas Camata <[email protected]> * Move custom query parameter into jsondata Signed-off-by: Douglas Camata <[email protected]> --------- Signed-off-by: Douglas Camata <[email protected]>
openshift-ci bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
…1264) (#1271) * Set max source resolution to auto in Grafana datasource * Move custom query parameter into jsondata --------- Signed-off-by: Douglas Camata <[email protected]> Co-authored-by: Douglas Camata <[email protected]>
openshift-ci bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
…1264) (#1272) * Set max source resolution to auto in Grafana datasource * Move custom query parameter into jsondata --------- Signed-off-by: Douglas Camata <[email protected]> Co-authored-by: Douglas Camata <[email protected]>
subbarao-meduri
pushed a commit
to subbarao-meduri/multicluster-observability-operator
that referenced
this pull request
Oct 27, 2023
…tolostron#1264) * Set max source resolution to auto in Grafana datasource Signed-off-by: Douglas Camata <[email protected]> * Move custom query parameter into jsondata Signed-off-by: Douglas Camata <[email protected]> --------- Signed-off-by: Douglas Camata <[email protected]>
openshift-ci bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
…1264) (#1273) * Set max source resolution to auto in Grafana datasource * Move custom query parameter into jsondata --------- Signed-off-by: Douglas Camata <[email protected]> Co-authored-by: Douglas Camata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACM-3748
Sets
max_source_resolution=autoin the Grafana datasource'scustomQueryParameters. This should force the underlying Thanos Query Frontend to perform additional queries for downsampled data in case of empty responses.