Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-8259] fix mco status update race condition #1265

Merged

Conversation

thibaultmg
Copy link
Contributor

Fix race condition in mco controller StartStatusUpdate function.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this makes sense!

@saswatamcode
Copy link
Member

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saswatamcode, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subbarao-meduri
Copy link
Collaborator

/test test-e2e

@subbarao-meduri
Copy link
Collaborator

/retest-required

@thibaultmg
Copy link
Contributor Author

Is this a regression or flaky test?
If this is a regression, let's discard this PR and we'll fix as we work more on the code base. This is just a quick fix as I was reading the code.

@subbarao-meduri
Copy link
Collaborator

/test test-e2e

Copy link

@openshift-merge-bot openshift-merge-bot bot merged commit 61cfcab into stolostron:main Jan 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants