Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACM-4384] defer unsafe Close vulnerability #1266

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[ACM-4384] defer unsafe Close vulnerability #1266

merged 1 commit into from
Oct 23, 2023

Conversation

subbarao-meduri
Copy link
Collaborator

This PR addresses the following issues

  1. ACM-4384 - defer unsafe close vulnerability
  2. Adds a diagnostic message when MCO reconcile is skipped waiting for MCH CR to be ready (upgrade)
  3. Miscellaneous warnings

CC: @bjoydeep @berenss - (2) should help diagnose MCO reconcile wasn't working as we saw in in ROSA HCP env

saswatamcode
saswatamcode approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This fixes a lot of issues! :)

@openshift-ci openshift-ci bot added the lgtm label Oct 19, 2023
@saswatamcode
Copy link
Member

/lgtm

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 19, 2023
View reviewed changes
proxy/pkg/util/util.go Fixed Show fixed Hide fixed
proxy/pkg/util/util.go Fixed Show fixed Hide fixed
loaders/dashboards/pkg/util/grafana_util.go Fixed Show fixed Hide fixed
loaders/dashboards/pkg/util/grafana_util.go Fixed Show fixed Hide fixed
tests/pkg/utils/mco_pods.go Fixed Show fixed Hide fixed
@openshift-ci openshift-ci bot removed the lgtm label Oct 19, 2023
@subbarao-meduri subbarao-meduri force-pushed the security-vulnerabilities branch 2 times, most recently from 97ab504 to 17602f1 Compare October 19, 2023 21:38
@subbarao-meduri
Copy link
Collaborator Author

/test pr-image-mirror-metrics-collector

@subbarao-meduri
Copy link
Collaborator Author

/retest-required

@subbarao-meduri subbarao-meduri force-pushed the security-vulnerabilities branch from 17602f1 to 34cd153 Compare October 20, 2023 13:28
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

25.7% 25.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2023 •
edited
Loading

@subbarao-meduri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 34cd153 link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

douglascamata
douglascamata approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglascamata, saswatamcode, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@subbarao-meduri subbarao-meduri merged commit 1179368 into stolostron:main Oct 23, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

@douglascamata douglascamata douglascamata approved these changes

Assignees

@douglascamata douglascamata

@saswatamcode saswatamcode

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subbarao-meduri @saswatamcode @douglascamata