Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add watch logic for addondeployment #1289

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

coleenquadros
Copy link
Contributor

https://issues.redhat.com/browse/RHOBS-949
https://issues.redhat.com/browse/ACM-8312

From what I understand is that the placement controller has no logic to watch over the changes to addondeployment config. So any update to it will not be picked up by managerclusteraddon and clustermanagementaddon which are watched already but they only hold a ref to addondeploymentconfig and not the actual config.

The PR adds the watch logic in the placement controller to monitor changes in addondeployment config and sets up the request to reconcile and also apply change to all managed clusters

@douglascamata
Copy link
Contributor

@coleenquadros there's an e2e test failing. Can you have a look, please?

@coleenquadros
Copy link
Contributor Author

/test test-unit

@coleenquadros
Copy link
Contributor Author

/retest

Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would love to achieve that 70% test coverage that SonarCloud is asking for though. It's fine if it's not feasible because we can't add 100% coverage of the proxy scenarios.

Copy link

openshift-ci bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, douglascamata

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Copy link

openshift-ci bot commented Jan 8, 2024

New changes are detected. LGTM label has been removed.

Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
Copy link
Contributor Author

/test test-unit

Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

47.6% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Jan 10, 2024

@coleenquadros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 842a2fb link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@coleenquadros
Copy link
Contributor Author

coleenquadros commented Jan 16, 2024

@subbarao-meduri Testing working as expected on QA test bed - changed the proxy setting values in addondeploymentconfig and the placement controller reconciled to pick up the new proxy settings

@subbarao-meduri subbarao-meduri merged commit 7fb7465 into stolostron:main Jan 18, 2024
12 of 15 checks passed
subbarao-meduri pushed a commit to subbarao-meduri/multicluster-observability-operator that referenced this pull request Jan 18, 2024
* add watch logic for addondeployment

Signed-off-by: Coleen Iona Quadros <[email protected]>

* make sonarcloud happy

Signed-off-by: Coleen Iona Quadros <[email protected]>

* lint

Signed-off-by: Coleen Iona Quadros <[email protected]>

* refactor predicate

Signed-off-by: Coleen Iona Quadros <[email protected]>

* lint

Signed-off-by: Coleen Iona Quadros <[email protected]>

* fix test case

Signed-off-by: Coleen Iona Quadros <[email protected]>

* refactor

Signed-off-by: Coleen Iona Quadros <[email protected]>

---------

Signed-off-by: Coleen Iona Quadros <[email protected]>
subbarao-meduri pushed a commit to subbarao-meduri/multicluster-observability-operator that referenced this pull request Jan 24, 2024
* add watch logic for addondeployment

Signed-off-by: Coleen Iona Quadros <[email protected]>

* make sonarcloud happy

Signed-off-by: Coleen Iona Quadros <[email protected]>

* lint

Signed-off-by: Coleen Iona Quadros <[email protected]>

* refactor predicate

Signed-off-by: Coleen Iona Quadros <[email protected]>

* lint

Signed-off-by: Coleen Iona Quadros <[email protected]>

* fix test case

Signed-off-by: Coleen Iona Quadros <[email protected]>

* refactor

Signed-off-by: Coleen Iona Quadros <[email protected]>

---------

Signed-off-by: Coleen Iona Quadros <[email protected]>
subbarao-meduri added a commit that referenced this pull request Jan 24, 2024
* add watch logic for addondeployment



* make sonarcloud happy



* lint



* refactor predicate



* lint



* fix test case



* refactor



---------

Signed-off-by: Coleen Iona Quadros <[email protected]>
Co-authored-by: Coleen Iona Quadros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants