-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hub metrics collector feature #1316
Hub metrics collector feature #1316
Conversation
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
Signed-off-by: clyang82 <[email protected]>
…ng in the spokes Signed-off-by: Coleen Iona Quadros <[email protected]>
Skipping CI for Draft Pull Request. |
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coleenquadros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c47191c
into
stolostron:hub-metrics-collector
if mcghCrdExists { | ||
mco.Spec.ObservabilityAddonSpec.EnableMetrics = false | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coleenquadros when MCGH CRD is detected, we don't want to standup hub Observability stack either (including Thanos). Not just spokes. We should do this check in https://github.com/stolostron/multicluster-observability-operator/blob/main/operators/multiclusterobservability/controllers/multiclusterobservability/multiclusterobservability_controller.go and bail out if detected.
* install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * modify endpoint operator Signed-off-by: clyang82 <[email protected]> * modify endpoint operator Signed-off-by: clyang82 <[email protected]> * check for global hub operator and prevent observability from installing in the spokes Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: clyang82 <[email protected]> Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: clyang82 <[email protected]>
* install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * modify endpoint operator Signed-off-by: clyang82 <[email protected]> * modify endpoint operator Signed-off-by: clyang82 <[email protected]> * check for global hub operator and prevent observability from installing in the spokes Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: clyang82 <[email protected]> Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: clyang82 <[email protected]>
* install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * modify endpoint operator Signed-off-by: clyang82 <[email protected]> * modify endpoint operator Signed-off-by: clyang82 <[email protected]> * check for global hub operator and prevent observability from installing in the spokes Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: clyang82 <[email protected]> Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: clyang82 <[email protected]>
* install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * install Metrics Without Addon Signed-off-by: clyang82 <[email protected]> * modify endpoint operator Signed-off-by: clyang82 <[email protected]> * modify endpoint operator Signed-off-by: clyang82 <[email protected]> * check for global hub operator and prevent observability from installing in the spokes Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: clyang82 <[email protected]> Signed-off-by: Coleen Iona Quadros <[email protected]> Co-authored-by: clyang82 <[email protected]>
No description provided.