Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHOBS-1009/ACM-8509]: Add ServiceMonitor for metrics-collector and instrument it properly #1336

Closed
wants to merge 56 commits into from
Closed

[RHOBS-1009/ACM-8509]: Add ServiceMonitor for metrics-collector and instrument it properly #1336

wants to merge 56 commits into from

Conversation

saswatamcode
Copy link
Member

This PR adds a ServiceMonitor for metrics-collector (both standard and uwl) and instruments both the federation and remote writing.

Not adding alerts directly, as we might want to test those first to see if it is flaky.

@saswatamcode saswatamcode self-assigned this Feb 20, 2024
@saswatamcode
Copy link
Member Author

/retest

1 similar comment
@saswatamcode
Copy link
Member Author

/retest

@saswatamcode
Copy link
Member Author

/test test-unit

philipgough
philipgough approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 21, 2024
@saswatamcode
Copy link
Member Author

/hold

@saswatamcode
Copy link
Member Author

/retest

2 similar comments
@saswatamcode
Copy link
Member Author

/retest

@saswatamcode
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot removed the lgtm label Feb 22, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 22, 2024

New changes are detected. LGTM label has been removed.

@saswatamcode saswatamcode force-pushed the mc-instr branch 3 times, most recently from 94dd16a to ad40c2a Compare February 22, 2024 13:45
@saswatamcode
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [philipgough,saswatamcode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coleenquadros and others added 22 commits February 26, 2024 01:31
@coleenquadros @subbarao-meduri
remove proxy changes
ebffbee 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros @subbarao-meduri
only watch endpoint
9d1f547 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros @subbarao-meduri
refactor hub metrics resource logic
da79987 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros @subbarao-meduri
clean resources
4520002 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@subbarao-meduri
Do not access mco resource after delete is initiated
a0705c2 
Signed-off-by: Subbarao Meduri <[email protected]>
@saswatamcode
[RHOBS-1009/ACM-8509]: Add ServiceMonitor for metrics-collector and i…
75406b0 
…nstrument it properly

Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
fix test
236bde0 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Add status code label to metrics and clean up
5eee2e6 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Ensure ServiceMonitor is properly configured and authenticated accord…
e2b68cf 
…ing to https://rhobs-handbook.netlify.app/products/openshiftmonitoring/collecting_metrics.md/

Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Fix lint
8650d23 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Use correct image for kube-rbac-proxy
0b8b663 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Correct indentation for kube-rbac-proxy secret
ea89fb2 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Correct servicemonitor and add ns monitoring label
eddbb8b 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Correct deployment label and test
d052a26 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Skip KRP
62a8247 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Final port/scheme fix
2d5c0b7 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Add local alerting rules
c753612 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Add apiextensionsv1 to scheme
d3bcd44 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Add resource version to crd update
c4d0625 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Fix formatting
be30901 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Only import once
fa93135 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Don't create krp resources
552dba9 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Fix lint
b19db57 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Fix lint
e33f472 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Comment unused
2506b11 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Copy link
Member Author

/retest

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
48.5% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 26, 2024

@saswatamcode: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 2506b11 link true /test sonarcloud
ci/prow/e2e-kind 2506b11 link true /test e2e-kind
ci/prow/test-e2e 2506b11 link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

@subbarao-meduri subbarao-meduri Awaiting requested review from subbarao-meduri

@coleenquadros coleenquadros Awaiting requested review from coleenquadros

Assignees

@philipgough philipgough

@saswatamcode saswatamcode

Labels
approved dco-signoff: yes do-not-merge/hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saswatamcode @philipgough @coleenquadros @subbarao-meduri