Add cluster:node_cpu:ratio to allowlist
#1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbaungard
force-pushed
the
ACM-10961-add-cluster-node-cpu-ratio
branch
from
2d027e0 to
7edb2b6
Compare
jacobbaungard
force-pushed
the
ACM-10961-add-cluster-node-cpu-ratio
branch
from
7edb2b6 to
b8c339b
Compare
|
Rebased with E2E-kind fixes. |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest 😩 |
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
We add this metric to the allowlist as it will be used to optimize dashboard performance for the fleet wide CPU widgets. Signed-off-by: Jacob Baungard Hansen <[email protected]>
jacobbaungard
force-pushed
the
ACM-10961-add-cluster-node-cpu-ratio
branch
from
b8c339b to
782410e
Compare
|
/test test-e2e |
1 similar comment
|
/test test-e2e |
|
/test test-e2e |
2 similar comments
|
/test test-e2e |
|
/test test-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobbaungard, philipgough, subbarao-meduri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
coleenquadros
pushed a commit
to coleenquadros/multicluster-observability-operator
that referenced
this pull request
May 23, 2024
We add this metric to the allowlist as it will be used to optimize dashboard performance for the fleet wide CPU widgets. Signed-off-by: Jacob Baungard Hansen <[email protected]>
jacobbaungard
added a commit
to jacobbaungard/multicluster-observability-operator
that referenced
this pull request
Jun 5, 2024
We add this metric to the allowlist as it will be used to optimize dashboard performance for the fleet wide CPU widgets. Signed-off-by: Jacob Baungard Hansen <[email protected]>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Add `cluster:node_cpu:ratio` to allowlist (#1409) We add this metric to the allowlist as it will be used to optimize dashboard performance for the fleet wide CPU widgets. Signed-off-by: Jacob Baungard Hansen <[email protected]> * Add optimized cluster overview dashboard This optimized dashboard mainly lowers the cardinality of the CPU metrics. Specifically instead of using `avg(rate(node_cpu_seconds_total` which has a cardinality of total CPUs across all managed clusters, we instead use `cluster:node_cpu:ratio` which has a cardinality of 1 per cluster. That is with 100 clusters, with 16 CPUs, the cardinality before was 100*16 = 1600, where as with this change we now only fetch 100 metrics. This should scale quite a bit better on larger installations with many clusters/nodes. Signed-off-by: Jacob Baungard Hansen <[email protected]> * Tests: Add basic test for dashboard existence A quick test that checks if the dashboards exists. Signed-off-by: Jacob Baungard Hansen <[email protected]> --------- Signed-off-by: Jacob Baungard Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add this metric to the allowlist as it will be used to optimize dashboard performance for the fleet wide CPU widgets.
The recording rule is already added to *ks clusters here:
multicluster-observability-operator/operators/endpointmetrics/manifests/prometheus/prometheusrules/kube-prometheus-node-recording.yaml
Line 24 in 7ed3670
The rule is slightly different from the the statistics we currently use in the dashboard. Before we counted everything except
idlecpu as "cpu utilization", while this rule also excludesiowaitandstreal, this aligns with how i.e node-exporter handle things, more info in the commit message here: prometheus/node_exporter@3e6f4ce