Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MCO v1beta1 api tests and deps #1417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove MCO v1beta1 api tests and deps #1417

wants to merge 1 commit into from

Conversation

philipgough
Copy link
Contributor

No description provided.

saswatamcode
saswatamcode approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [philipgough,saswatamcode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@philipgough philipgough force-pushed the remove-deprecated-apis branch from 66fb66d to a5b47a2 Compare April 29, 2024 09:03
@openshift-ci openshift-ci bot removed the lgtm label Apr 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 29, 2024

New changes are detected. LGTM label has been removed.

@philipgough
Copy link
Contributor Author

/test e2e-kind

@philipgough
Copy link
Contributor Author

/retest

@philipgough philipgough force-pushed the remove-deprecated-apis branch from a5b47a2 to 132f4bf Compare April 29, 2024 14:49
@philipgough philipgough force-pushed the remove-deprecated-apis branch from 132f4bf to faf4dd9 Compare May 8, 2024 09:44
@subbarao-meduri subbarao-meduri force-pushed the remove-deprecated-apis branch from faf4dd9 to 4f14b94 Compare May 18, 2024 10:40
@philipgough philipgough force-pushed the remove-deprecated-apis branch from 4f14b94 to 66e6eee Compare May 31, 2024 10:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 31, 2024

@philipgough: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e 66e6eee link true /test test-e2e
ci/prow/e2e-kind 66e6eee link true /test e2e-kind

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees

@saswatamcode saswatamcode

Labels
approved dco-signoff: yes needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipgough @openshift-merge-robot @saswatamcode