Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACM-6685] Validate url for external remote write endpoint #1432

Merged
merged 1 commit into from
May 20, 2024
Merged

[ACM-6685] Validate url for external remote write endpoint #1432

merged 1 commit into from
May 20, 2024

Conversation

philipgough
Copy link
Contributor

@philipgough philipgough commented May 10, 2024 •
edited
Loading

@philipgough philipgough changed the title Validate url for external remote write endpoint [ACM-6685]Validate url for external remote write endpoint May 10, 2024
@philipgough philipgough changed the title [ACM-6685]Validate url for external remote write endpoint [ACM-6685] Validate url for external remote write endpoint May 10, 2024
@philipgough
Copy link
Contributor Author

/test test-e2e

1 similar comment
@philipgough
Copy link
Contributor Author

/test test-e2e

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@philipgough
Copy link
Contributor Author

/test test-e2e

5 similar comments
@philipgough
Copy link
Contributor Author

/test test-e2e

@philipgough
Copy link
Contributor Author

/test test-e2e

@philipgough
Copy link
Contributor Author

/test test-e2e

@subbarao-meduri
Copy link
Collaborator

/test test-e2e

@philipgough
Copy link
Contributor Author

/test test-e2e

saswatamcode
saswatamcode approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipgough, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@philipgough philipgough merged commit 68e7b45 into stolostron:main May 20, 2024
15 checks passed
coleenquadros pushed a commit to coleenquadros/multicluster-observability-operator that referenced this pull request May 23, 2024
@philipgough @coleenquadros
Validate url for external remote write endpoint (stolostron#1432)
103e6d4 
Signed-off-by: Philip Gough <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees

@saswatamcode saswatamcode

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipgough @subbarao-meduri @saswatamcode