Add optimized grafana dashboard #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test test-unit |
|
Skipping CI for Draft Pull Request. |
|
/test test-unit |
3 similar comments
|
/test test-unit |
|
/test test-unit |
|
/test test-unit |
jacobbaungard
force-pushed
the
ACM-10962-dashboard-optimization
branch
from
84ec537 to
776c7a2
Compare
|
/test test-unit |
jacobbaungard
force-pushed
the
ACM-10962-dashboard-optimization
branch
4 times, most recently
from
899d86a to
0e2886c
Compare
|
/test images |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-kind |
jacobbaungard
force-pushed
the
ACM-10962-dashboard-optimization
branch
from
c96d7b6 to
939fbbd
Compare
This optimized dashboard mainly lowers the cardinality of the CPU metrics. Specifically instead of using `avg(rate(node_cpu_seconds_total` which has a cardinality of total CPUs across all managed clusters, we instead use `cluster:node_cpu:ratio` which has a cardinality of 1 per cluster. That is with 100 clusters, with 16 CPUs, the cardinality before was 100*16 = 1600, where as with this change we now only fetch 100 metrics. This should scale quite a bit better on larger installations with many clusters/nodes. Signed-off-by: Jacob Baungard Hansen <[email protected]>
Instead of listing all clusters manually in the query, i.e like: ``` cluster=~"(local-cluster|simulated-managed-cluster-1|simulated-managed-cluster-1-1|simulated-managed-cluster-1-10|simulated-managed-cluster-1-2|simulated-managed-cluster-1-3..." ``` We set it to `".+"` simplifying the query significantly. Signed-off-by: Jacob Baungard Hansen <[email protected]>
A quick test that checks if the dashboards exists. Signed-off-by: Jacob Baungard Hansen <[email protected]>
jacobbaungard
force-pushed
the
ACM-10962-dashboard-optimization
branch
from
bb0437f to
ba93d28
Compare
While the auxiliary images (endpoint-monitoring-operator, etc) correctly used the CI built images in kind, this was that the case for MCO itself. In this commit we make sure to load in the `IMAGE REF` from the kind env file, so that the CI image for MCO is used as well. Signed-off-by: Jacob Baungard Hansen <[email protected]>
jacobbaungard
force-pushed
the
ACM-10962-dashboard-optimization
branch
from
ba93d28 to
ad9b81a
Compare
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobbaungard, subbarao-meduri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jacobbaungard
added a commit
to jacobbaungard/multicluster-observability-operator
that referenced
this pull request
May 28, 2024
These were missed before merging: stolostron#1454 Signed-off-by: Jacob Baungard Hansen <[email protected]>
jacobbaungard
added a commit
to jacobbaungard/multicluster-observability-operator
that referenced
this pull request
May 31, 2024
These were missed before merging: stolostron#1454 Signed-off-by: Jacob Baungard Hansen <[email protected]>
jacobbaungard
added a commit
that referenced
this pull request
May 31, 2024
These were missed before merging: #1454 Signed-off-by: Jacob Baungard Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimized dashboard mainly lowers the cardinality of the CPU
metrics. Specifically instead of using
avg(rate(node_cpu_seconds_totalwhich has a cardinality of total CPUs across all managed clusters, we
instead use
cluster:node_cpu:ratiowhich has a cardinality of 1 percluster.
That is with 100 clusters, with 16 CPUs, the cardinality before was
100*16 = 1600, where as with this change we now only fetch 100 metrics.
This should scale quite a bit better on larger installations with many
clusters/nodes.