[ACM-11543] Check if URL already contains remote write path before appending it #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Camata <[email protected]>
thibaultmg
reviewed
May 29, 2024
operators/multiclusterobservability/controllers/placementrule/hub_info_secret.go
Outdated
Show resolved
Hide resolved
thibaultmg
reviewed
May 29, 2024
operators/multiclusterobservability/controllers/placementrule/hub_info_secret.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Douglas Camata <[email protected]>
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
…ty-operator into fix-hardcoded-remote-write-path Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: Douglas Camata <[email protected]>
douglascamata
force-pushed
the
fix-hardcoded-remote-write-path
branch
from
bd34b40 to
2fb842e
Compare
|
/retest-required |
Signed-off-by: Douglas Camata <[email protected]>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglascamata, thibaultmg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the reverse proxy/LB support, the remote write endpoint could be under a custom path prefix (i.e.
host:port/custom-path//api/metrics/v1/default/api/v1/receive).We can't hardcoded the path directly to
/api/metrics/v1/default/api/v1/receive. So the best way forward if to append this path to the url as a string, unless it's already present, then parse it into anurl.URL.