Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-10544] Upgrade addon-manager and k8s libs through custom controller-filtered-cache #1468

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

douglascamata
Copy link
Contributor

@douglascamata douglascamata commented Jun 5, 2024

This uses a fork of the https://github.com/IBM/controller-filtered-cache, available at https://github.com/stolostron/controller-filtered-cache/tree/upgrade-k8s-deps. The fork is updated to k8s libs 0.29.z and controller-runtime 0.17.z (the last ones that can be built with Go 1.21). A PR was opened upstream to contribute back the patch (IBM/controller-filtered-cache#35).

Copy link

openshift-ci bot commented Jun 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@douglascamata
Copy link
Contributor Author

/test test-unit

@douglascamata douglascamata force-pushed the addon-manager-upgrade-efc-change branch from a5fa029 to a3564db Compare June 5, 2024 12:32
@douglascamata
Copy link
Contributor Author

/test test-unit

@douglascamata
Copy link
Contributor Author

/test test-unit

@douglascamata douglascamata marked this pull request as ready for review June 5, 2024 13:23
@douglascamata douglascamata changed the title Upgrade addon-manager and k8s libs through custom controller-filtered-cache [ACM-10544] Upgrade addon-manager and k8s libs through custom controller-filtered-cache Jun 5, 2024
@philipgough
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 6, 2024
…ty-operator into addon-manager-upgrade-efc-change

Signed-off-by: Douglas Camata <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jun 6, 2024
@philipgough
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 6, 2024
Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglascamata, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [douglascamata,philipgough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.3% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Jun 6, 2024

@douglascamata: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 135ed03 link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@douglascamata douglascamata merged commit c43b44f into main Jun 6, 2024
13 of 15 checks passed
@douglascamata douglascamata deleted the addon-manager-upgrade-efc-change branch June 6, 2024 13:51
periklis pushed a commit to periklis/multicluster-observability-operator that referenced this pull request Jun 10, 2024
…ler-filtered-cache (stolostron#1468)

* Upgrade addon-manager and k8s libs

Signed-off-by: Douglas Camata <[email protected]>

* Fix Grafana deployment file modified by accident

Signed-off-by: Douglas Camata <[email protected]>

---------

Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: Periklis Tsirakidis <[email protected]>
periklis pushed a commit to periklis/multicluster-observability-operator that referenced this pull request Jun 10, 2024
…ler-filtered-cache (stolostron#1468)

* Upgrade addon-manager and k8s libs

Signed-off-by: Douglas Camata <[email protected]>

* Fix Grafana deployment file modified by accident

Signed-off-by: Douglas Camata <[email protected]>

---------

Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: Periklis Tsirakidis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants