Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused query to get obs api route-host #1471

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Remove unused query to get obs api route-host #1471

merged 1 commit into from
Jun 7, 2024

Conversation

douglascamata
Copy link
Contributor

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@douglascamata
Copy link
Contributor Author

/retest-required

1 similar comment
@douglascamata
Copy link
Contributor Author

/retest-required

philipgough
philipgough approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 7, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglascamata, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b489cd8 into main Jun 7, 2024
16 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the remove-unrequired-query branch June 7, 2024 14:33
periklis pushed a commit to periklis/multicluster-observability-operator that referenced this pull request Jun 10, 2024
@douglascamata @periklis
Remove unused query to get obs api route-host (stolostron#1471)
83472c6 
Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: Periklis Tsirakidis <[email protected]>
periklis pushed a commit to periklis/multicluster-observability-operator that referenced this pull request Jun 10, 2024
@douglascamata @periklis
Remove unused query to get obs api route-host (stolostron#1471)
a34da27 
Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: Periklis Tsirakidis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

Assignees

@philipgough philipgough

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglascamata @philipgough