Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcoa: bump logging resources to 6.0 #1626

Merged

Conversation

JoaoBraveCoding
Copy link
Contributor

Copy link

openshift-ci bot commented Sep 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@JoaoBraveCoding
Copy link
Contributor Author

/test e2e-kind

@@ -35,7 +35,7 @@ spec:
- name: global
namespace: open-cluster-management-global-set
configs:
- group: logging.openshift.io
- group: observability.openshift.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change from upstream, or does it distinguish MCOA CR's as separate to the CLF installed CR's?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Logging Operator 6.0 the logging team deprecated the old CRDs and created a new one, it's still called ClusterLogForwarder but they belong to a different group.

TL;DR: Upstream, they are still the CR's managed by CLO

@openshift-ci openshift-ci bot added the lgtm label Oct 1, 2024
@JoaoBraveCoding
Copy link
Contributor Author

/retest-required

@JoaoBraveCoding
Copy link
Contributor Author

/test test-e2e

1 similar comment
@jacobbaungard
Copy link
Contributor

/test test-e2e

@openshift-ci openshift-ci bot removed the lgtm label Oct 2, 2024
Copy link

sonarqubecloud bot commented Oct 2, 2024

@JoaoBraveCoding
Copy link
Contributor Author

/test test-e2e

Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, moadz, periklis, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JoaoBraveCoding,moadz,periklis,philipgough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 983141d into stolostron:main Oct 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants