-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcoa: bump logging resources to 6.0 #1626
mcoa: bump logging resources to 6.0 #1626
Conversation
Skipping CI for Draft Pull Request. |
PR with precedence: stolostron/multicluster-observability-addon#63 Signed-off-by: Joao Marcal <[email protected]>
141876d
to
b28cb6e
Compare
/test e2e-kind |
@@ -35,7 +35,7 @@ spec: | |||
- name: global | |||
namespace: open-cluster-management-global-set | |||
configs: | |||
- group: logging.openshift.io | |||
- group: observability.openshift.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change from upstream, or does it distinguish MCOA CR's as separate to the CLF installed CR's?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Logging Operator 6.0 the logging team deprecated the old CRDs and created a new one, it's still called ClusterLogForwarder
but they belong to a different group.
TL;DR: Upstream, they are still the CR's managed by CLO
/retest-required |
/test test-e2e |
1 similar comment
/test test-e2e |
Quality Gate passedIssues Measures |
/test test-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoaoBraveCoding, moadz, periklis, philipgough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR with precedence: stolostron/multicluster-observability-addon#63