Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic.DeepEqual for Kubernetes Obj comparison #1666

Closed
wants to merge 1 commit into from

Conversation

coleenquadros
Copy link
Contributor

No description provided.

Signed-off-by: Coleen Iona Quadros <[email protected]>
Copy link

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coleenquadros coleenquadros changed the title Use deepEqual for Kubernetes Obj comparison Use semantic.DeepEqual for Kubernetes Obj comparison Nov 11, 2024
Copy link

@coleenquadros
Copy link
Contributor Author

/retest-required

@coleenquadros
Copy link
Contributor Author

/cherry-pick release-2.12

@openshift-cherrypick-robot
Copy link
Collaborator

@coleenquadros: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coleenquadros
Copy link
Contributor Author

/retest

1 similar comment
@coleenquadros
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Nov 11, 2024

@coleenquadros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-unit 0d95762 link true /test test-unit
ci/prow/pr-image-mirror-endpoint-monitoring-operator 0d95762 link true /test pr-image-mirror-endpoint-monitoring-operator
ci/prow/e2e-kind 0d95762 link true /test e2e-kind
ci/prow/images 0d95762 link true /test images
ci/prow/test-e2e 0d95762 link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@coleenquadros coleenquadros deleted the refactor branch January 14, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants