[main] Render: fail if no oauth image is found #1672
Conversation
For some unknown reason, during upgrades from ACM 2.11, the template image is briefly used, instead of the image from the openshift imagestream. The template image is not available in disconnected environments, and as a result causes the pods be unable to come up. This is a problem especially for alertmanager. Because of it being a statefulset when it gets into the bad state, with the wrong image, it doesn't automatically recover on the next reconcile. This requires manual intervention to fix. Instead with this PR, we make the reconcile fail if we do not find the oauth image. This will make it retry later, when the imagestream is able to be found. Signed-off-by: Jacob Baungard Hansen <[email protected]>
Instead of passing through the `ImageV1Client` we instead use the interface `ImageV1Interface`. This is so we're able to pass in a faked ImageClient for tests. This is needed because since reconciles, as per the previous commit, will actually fail if we cannot get the image from the imagestream. Signed-off-by: Jacob Baungard Hansen <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
|
/retest-required |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Superseded by: #1677 |
This is an automated cherry-pick of #1669
/assign jacobbaungard