Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.11] [ACM-16335] Reconcile MCO only when there is actual change in mch image manifest #1731

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[release-2.11] [ACM-16335] Reconcile MCO only when there is actual change in mch image manifest #1731

merged 1 commit into from
Dec 20, 2024

Conversation

coleenquadros
Copy link
Contributor

No description provided.

@coleenquadros coleenquadros changed the title cherry pick 2.11 [release-2.11] [ACM-16335] Reconcile MCO only when there is actual change in mch image manifest Dec 18, 2024
@coleenquadros
cherry pick 2.11
aa585d9 
Signed-off-by: Coleen Iona Quadros <[email protected]>
@coleenquadros
Copy link
Contributor Author

/retest-required

@coleenquadros
Copy link
Contributor Author

/meow caturday

@coleenquadros
Copy link
Contributor Author

/retest

1 similar comment
@coleenquadros
Copy link
Contributor Author

/retest

philipgough
philipgough approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [coleenquadros,philipgough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coleenquadros
Copy link
Contributor Author

/retesr-required

@coleenquadros
Copy link
Contributor Author

/retest-required

@coleenquadros
Copy link
Contributor Author

/retest

1 similar comment
@coleenquadros
Copy link
Contributor Author

/retest

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.1% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2024

@coleenquadros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud aa585d9 link false /test sonarcloud
ci/prow/test-e2e aa585d9 link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@coleenquadros coleenquadros merged commit eb94214 into stolostron:release-2.11 Dec 20, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

Assignees

@philipgough philipgough

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coleenquadros @philipgough