Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.12] Fix leaky goroutine on metrics-collector (#1733) #1734

Open
wants to merge 1 commit into
base: release-2.12
Choose a base branch
from
Open

[release-2.12] Fix leaky goroutine on metrics-collector (#1733) #1734

wants to merge 1 commit into from

Conversation

saswatamcode
Copy link
Member

  • Fix leaky goroutine on metrics-collector

  • Check simulated series file

  • Fix test

@saswatamcode
Fix leaky goroutine on metrics-collector (stolostron#1733)
adb485f 
* Fix leaky goroutine on metrics-collector

Signed-off-by: Saswata Mukherjee <[email protected]>

* Check simulated series file

Signed-off-by: Saswata Mukherjee <[email protected]>

* Fix test

Signed-off-by: Saswata Mukherjee <[email protected]>

---------

Signed-off-by: Saswata Mukherjee <[email protected]>
jacobbaungard
jacobbaungard approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@jacobbaungard jacobbaungard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jacobbaungard,saswatamcode]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 19, 2024

@saswatamcode: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud adb485f link false /test sonarcloud
ci/prow/test-e2e adb485f link true /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@saswatamcode
Copy link
Member Author

retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbaungard jacobbaungard jacobbaungard approved these changes

Assignees

@jacobbaungard jacobbaungard

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saswatamcode @jacobbaungard