Fix: list of managedClusters in e2e tests for AlertManager #1820
+97
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
Signed-off-by: Thibault Mange <[email protected]>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobbaungard, thibaultmg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thibaultmg
added a commit
to thibaultmg/multicluster-observability-operator
that referenced
this pull request
Feb 3, 2025
…n#1820) * fix list of managedClusters Signed-off-by: Thibault Mange <[email protected]> * fix Signed-off-by: Thibault Mange <[email protected]> * fix getting cluster ID, add logs Signed-off-by: Thibault Mange <[email protected]> --------- Signed-off-by: Thibault Mange <[email protected]>
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Fix e2e watchdog alert test (#1805) * fix watchdog alerts test Signed-off-by: Thibault Mange <[email protected]> * fix Signed-off-by: Thibault Mange <[email protected]> * Revert "fix" This reverts commit 995617a. * add logs Signed-off-by: Thibault Mange <[email protected]> * Update tests/pkg/tests/observability_alert_test.go Co-authored-by: Jacob Baungård Hansen <[email protected]> --------- Signed-off-by: Thibault Mange <[email protected]> Co-authored-by: Jacob Baungård Hansen <[email protected]> * Fix: list of managedClusters in e2e tests for AlertManager (#1820) * fix list of managedClusters Signed-off-by: Thibault Mange <[email protected]> * fix Signed-off-by: Thibault Mange <[email protected]> * fix getting cluster ID, add logs Signed-off-by: Thibault Mange <[email protected]> --------- Signed-off-by: Thibault Mange <[email protected]> --------- Signed-off-by: Thibault Mange <[email protected]> Co-authored-by: Jacob Baungård Hansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an invalid assertion in e2e tests introduced by #1805 (see details in #1808 (comment)).
And only list available ManagedClusters (this is necessary for some other environments running our e2e suite).