Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements to latest versions #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update requirements to latest versions #73

wants to merge 2 commits into from

Conversation

bertildaniel
Copy link

Update requirements to latest versions and update all flask.ext.x imports to flask_x format (only affecting tests and docs).

There was an issue with the deleted user signal which was triggering a refetching of the Account from Stormpath (failing with an exception) when the User object was dispatched by blinker. I've made a slightly hacky workaround to prevent that re-fetch as I could find no way in the stormpath library to prevent the re-fetch and/or internally track that the resource was just deleted. It seems this is something that needs be fixed in the stormpath library.

With the upgrade to flask-login 0.3.2 there is a breaking change in the interface, where User.is_authenticated etc become properties.

I've tested this on Python 3.5.2 (which I'm using) and also tests pass on Python 2.7.12.

…enting all tests from passing

Update all flask.ext.x imports to flask_x format (only affecting tests and docs)
@jcass77
Copy link
Contributor

jcass77 commented Sep 5, 2016

Should you not perhaps create this PR against the 'develop' branch to be merged? Some of the dependencies have already been upgraded there (thought not quite as high as you have here).

It look like steps have already been taken to change the user deletion behaviour as well (see

def delete(self):
"""
Send signal after user is deleted.
"""
user_dict = dict(self)
return_value = super(User, self).delete()
user_deleted.send(None, user=user_dict)
return return_value
) - not sure if that fixes the problem you described though.

@bertildaniel
Copy link
Author

bertildaniel commented Sep 5, 2016

@jcass77 I did briefly look at the develop branch and it didn't seem like it was being kept up to date with master? The only thing on develop that is not covered by this PR is the changes to supported languages in travis.yml and setup.py which could be added here.

The delete changes on that branch would break the current signal behaviour (as it stands in release 0.4.5) of sending the actual User object with the signal. Of course could change to use a dict instead - I don't have any particular opinion on that as I'm not using the functionality, but that would affect anyone who has already built things on top of current behaviour.

@jcass77
Copy link
Contributor

jcass77 commented Sep 18, 2016

A lot of this has since landed in 'develop' (except for the user delete signaling).

If you could rebase this PR on 'develop' the maintainers might be able to take another look at it.

@rdegges
Copy link
Contributor

rdegges commented Sep 19, 2016

Yes, if you could rebase that'd be awesome. If not I'll take a look at this next week and go through and just pick out the relevant bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants