Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "link" to "video" for embed type. #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change "link" to "video" for embed type. #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c181aa
Fixed iframe embed
tjkohli Jun 20, 2022
376344a
Changed incorrect type for video embed
tjkohli Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/kramdown/converter/prismic.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,14 @@ def convert_sub_html_element(element, type)
def convert_html_element(element)
if element.value == 'iframe'
{
type: 'embed',
data: {
embed_url: element.attr['src'],
type: 'video'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we don't really know that it's an embed. But when I tested it on primisc, it was working as expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't choose video, the embed import fails completely. What are your thoughts to resolve this

Copy link
Collaborator

@francois2metz francois2metz Aug 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any error message that explain the problem?

},
content: {
spans: [],
text: ''
},
type: 'embed',
data: {
embed_url: 'https://www.youtube.com/watch?v=dQw4w9WgXcQ',
type: 'link'
}
}
else
Expand Down