Refactor client initialization logic to use a generic lazy-loaded method #265
Conversation
Replaced individual client initializations with a getClient method that lazily loads and stores clients in a single object. This reduces code duplication and simplifies the management of client instances.
cypherpepe
requested review from
DonFungible,
edisonz0718,
jacob-tucker and
AndyBoWu
as code owners
edisonz0718
requested review from
LeoHChen,
allenchuang,
bpolania,
bonnie57 and
DracoLi
as code owners
There was a problem hiding this comment.
Hi @cypherpepe,
Thank you so much for your contribution and for taking the time to submit this PR! We really appreciate your effort and insights.
The idea of a generic lazy-loaded method is excellent! I’ve left a few comments for potential enhancements. Please take a look when you have a chance.
Thanks again for your support and for helping us improve! 🚀
| private _ipAccount: IPAccountClient | null = null; | ||
| private _royalty: RoyaltyClient | null = null; | ||
| private _nftClient: NftClient | null = null; | ||
| private _clients: { [key: string]: any } = {}; |
There was a problem hiding this comment.
We need to create a type-safe client to avoid using any. For example, define client-specific types:
type ClientRegistry = {
ipAsset: IPAssetClient;
permission: PermissionClient;
// ...
};| * this method is called. | ||
| * | ||
| * @returns the IPAssetClient instance | ||
| * @param clientName - the name of the client | ||
| * @param ClientClass - the class of the client |
There was a problem hiding this comment.
We now prefer using inline annotation. Could you use it as well?
| public get ipAsset(): IPAssetClient { | ||
| if (this._ipAsset === null) { | ||
| this._ipAsset = new IPAssetClient(this.rpcClient, this.wallet, this.config.chainId); | ||
| private getClient<T>(clientName: string, ClientClass: new (...args: any[]) => T): T { |
There was a problem hiding this comment.
If the client type is ClientRegistry, you can use the following code. You also need to consider the chainId inconsistency issue.
private getClient<K extends keyof ClientRegistry>(
clientName: K,
ClientClass: new (
rpcClient: PublicClient,
wallet: SimpleWalletClient,
chainId?: ChainIds
) => ClientRegistry[K]
): ClientRegistry[K]
Replaced individual client initializations with a getClient method that lazily loads and stores clients in a single object. This reduces code duplication and simplifies the management of client instances.
Description
This PR refactors the client initialization logic by introducing a getClient method that lazily loads and caches clients in a single object. The previous approach initialized each client separately, leading to duplicated code and less maintainability. The new method reduces redundancy and makes the code more modular and easier to extend.
Test Plan
Related Issue
No related issue. This is an internal refactoring to improve code structure.
Notes
No additional front-end or navigation changes required.