Package Release Workflow Fixes #503
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpolania
requested review from
LeoHChen,
DonFungible,
edisonz0718,
jacob-tucker,
AndyBoWu,
allenchuang,
bonnie57 and
DracoLi
as code owners
DracoLi
reviewed
Apr 7, 2025
| @@ -7,6 +7,10 @@ on: | |||
| type: string | |||
| required: true | |||
| description: "Tag version to be published" | |||
| last_tag: | |||
There was a problem hiding this comment.
do we need this? we don't need the release log to be generated right?
There was a problem hiding this comment.
We are using Mike Penze's github action and it requires a value for the fromTag input.
There was a problem hiding this comment.
since we are creating the release docs ourselves, do we still need this?
There was a problem hiding this comment.
That action is for releasing the npm package, I mean, I don't think it's related with the docs.
DracoLi
previously approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues with the
npmrelease flow