Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize STREAM #148

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Parallelize STREAM #148

wants to merge 4 commits into from

Conversation

str4d
Copy link
Owner

@str4d str4d commented Nov 4, 2020

Part of #271.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #148 (4f72ab0) into main (456ce70) will increase coverage by 0.99%.
The diff coverage is 63.96%.

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   33.56%   34.55%   +0.99%     
==========================================
  Files          34       34              
  Lines        3081     3102      +21     
==========================================
+ Hits         1034     1072      +38     
+ Misses       2047     2030      -17     
Impacted Files Coverage Δ
age/src/primitives/stream.rs 58.13% <63.96%> (-1.35%) ⬇️
age/tests/test_vectors.rs 79.16% <0.00%> (-4.17%) ⬇️
age/src/format.rs 58.02% <0.00%> (-3.23%) ⬇️
age/src/protocol.rs 68.79% <0.00%> (-1.92%) ⬇️
age/src/keys.rs 80.00% <0.00%> (-1.82%) ⬇️
age/src/encrypted.rs 41.30% <0.00%> (-1.71%) ⬇️
age/src/plugin.rs 4.58% <0.00%> (-0.46%) ⬇️
age/src/util.rs 57.14% <0.00%> (ø)
age/src/error.rs 2.23% <0.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@paulmillr
Copy link

Would be great to have this merged! Filippo doesn't seem to work on age much, so I think it's fine to make rage different in some regards.

Base automatically changed from master to main January 30, 2021 14:34
@tarcieri
Copy link

tarcieri commented Nov 8, 2021

Would love to have something like this upstream in the aead crate 😉

@str4d
Copy link
Owner Author

str4d commented Nov 8, 2021

The current issue with this PR is that it provides way too little performance improvement for the CPU cost it incurs. I still need to dig into this and figure out why.

@str4d str4d marked this pull request as draft March 7, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants