Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug Challenge - DO NOT MERGE #53

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Shows administrator the subscription price being paid for a group account when managing a group.
Screenshot 2025-02-24 at 4 53 21 PM

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005
Copy link
Member Author

dparker1005 commented Feb 25, 2025

Answers

Functional Issues:

  • Line 400: esc_html_e() => esc_html__ if there is no subscription.
    Screenshot 2025-02-25 at 9 10 43 AM
  • Lines 400 and 424: Incorrect text domain paid-memberships-pro

Security Issues:

  • Line 423: Missing esc_attr()

Fatal Errors:

  • Line 399: The PMPro_Subscription class was introduced in PMPro v3.0. We still need backward compatibility for PMPro v2.x.
  • Entire function: This function is a callback to a shortcode that runs even if PMPro is inactive. This means that if PMPro is inactive, PMPro-specific functions like pmpro_get_element_class() will cause fatal errors when this shortcode is rendered. This is not only an issue in this PR, but in the existing function.

@dparker1005 dparker1005 deleted the debug-challenge-subscription-price branch February 25, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant