You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added justify-content: center and align-items: center to the parent container named CheckboxIndicator located in
packages\design-system\src\components\Checkbox\Checkbox.tsx
Why is it needed?
Checkbox Icon was not centered within parent container
How to test it?
You can test this feature by running the application and attempting the checkbox module.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
PlanckConst
changed the title
fix: checkbox Icon was uncentered because missing justify content in parent container
fix: checkbox Icon was uncentered because missing justify content and align items in parent container
Nov 14, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlanckConst
changed the title
hanpaine
added
pr: fix
What was changed?
Added justify-content: center and align-items: center to the parent container named CheckboxIndicator located in
packages\design-system\src\components\Checkbox\Checkbox.tsx
Why is it needed?
Checkbox Icon was not centered within parent container
How to test it?
You can test this feature by running the application and attempting the checkbox module.
Related issue(s)/PR(s)
Related Issue: #1819
fixes #1819