feat: add disabled state to the create item option #1911
+84
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simotae14
added
pr: feature
🦋 Changeset detectedLatest commit: 2c39d3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
remidej
reviewed
May 5, 2025
There was a problem hiding this comment.
I think you should include this story in the storybook docs page too
| @@ -47,6 +47,7 @@ interface ComboboxProps | |||
| Omit<ComboboxPrimitive.TextInputProps, 'required' | 'disabled' | 'value' | 'onChange' | 'size'> { | |||
| clearLabel?: string; | |||
| creatable?: boolean | 'visible'; | |||
| creatableDisabled?: boolean; | |||
There was a problem hiding this comment.
fyi the props table doesn't receive the type properly
Comment on lines
+438
to
+442
| &&[data-disabled] { | ||
| color: ${({ theme }) => theme.colors.neutral600}; | ||
| background: ${({ theme }) => theme.colors.neutral150}; | ||
| cursor: not-allowed; | ||
| } |
There was a problem hiding this comment.
there's a small visual issue with the border radii
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add a new disabled state, and style, to the Combobox Create item option
Why is it needed?
We want to show the combobox options and disable the combobox create item button in case the user has no permission to create an item.
How to test it?
In the storybook you can find a new Combobox Creatable disabled section to check the solution provided.
Related issue(s)/PR(s)
CS-1405