Stop pool changes #3297
Merged
Stop pool changes #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaublitz
force-pushed
the
stop-pool-changes
branch
2 times, most recently
from
9331a20 to
7e99d23
Compare
jbaublitz
force-pushed
the
stop-pool-changes
branch
from
7e99d23 to
2b1e088
Compare
jbaublitz
force-pushed
the
stop-pool-changes
branch
from
2b1e088 to
2beec09
Compare
jbaublitz
force-pushed
the
stop-pool-changes
branch
from
83a1a63 to
78ad40e
Compare
This commit makes two changes: * Switch D-Bus API from D-Bus object path to pool UUID or name to allow stopping partially constructed pools. * Modify engine to tear down partially constructed pools for r6 and later. Otherwise treat partially constructed pools as stopped.
jbaublitz
force-pushed
the
stop-pool-changes
branch
from
78ad40e to
ce6bb76
Compare
This was referenced May 2, 2023
mulkieran
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3285
Blocked by #3295