Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in sim engine #3740

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix bug in sim engine #3740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/engine/sim_engine/engine.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,14 +346,26 @@ impl Engine for SimEngine {
.map(|(n, p)| (n, u, p))?,
};
if pool.is_encrypted() && unlock_method.is_none() {
self.stopped_pools
.write()
.await
.insert(name, pool_uuid, pool);
return Err(StratisError::Msg(format!(
"Pool with UUID {pool_uuid} is encrypted but no unlock method was provided"
)));
} else if !pool.is_encrypted() && unlock_method.is_some() {
self.stopped_pools
.write()
.await
.insert(name, pool_uuid, pool);
return Err(StratisError::Msg(format!(
"Pool with UUID {pool_uuid} is not encrypted but an unlock method was provided"
)));
} else if !pool.is_encrypted() && passphrase_fd.is_some() {
self.stopped_pools
.write()
.await
.insert(name, pool_uuid, pool);
return Err(StratisError::Msg(format!(
"Pool with UUID {pool_uuid} is not encrypted but a passphrase was provided"
)));
Expand Down