Pass time when test ended to DbusMonitor test #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
force-pushed
the
issue_ci_241
branch
from
276534a to
79da690
Compare
Also, change name of check methods from tearDown to run_check. "tearDown" has a special meaning for TestCase classes which these methods do not have. Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
issue_ci_241
branch
from
79da690 to
b76735e
Compare
mulkieran
changed the title
|
This should go in before #239 |
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Feb 26, 2024
Signed-off-by: mulhern <[email protected]>
|
If stratis-storage/stratisd#3545 checks out, this is actually trivial. |
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Feb 26, 2024
Signed-off-by: mulhern <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #239