Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for filesystem debug get-metadata #275

Merged

Conversation

bgurney-rh
Copy link
Member

@bgurney-rh bgurney-rh commented Aug 5, 2024

Related: #274

@bgurney-rh bgurney-rh self-assigned this Aug 5, 2024
@bgurney-rh bgurney-rh marked this pull request as ready for review August 5, 2024 17:44
@bgurney-rh bgurney-rh changed the title stratis_cli_cert: add test for filesystem debug get-metadata Add tests for filesystem debug get-metadata Aug 5, 2024
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of changes, then it should be ready.

testlib/dbus.py Show resolved Hide resolved
stratis_cli_cert.py Outdated Show resolved Hide resolved
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last request...

testlib/dbus.py Show resolved Hide resolved
Copy link
Member

@mulkieran mulkieran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please squash and we can merge.

@bgurney-rh bgurney-rh force-pushed the tests-fs-debug-getmetadata branch from 407ef58 to 803baee Compare August 6, 2024 14:11
@bgurney-rh
Copy link
Member Author

OK; squashed into a single commit.

@mulkieran mulkieran merged commit 712f2b4 into stratis-storage:master Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done (2)
Development

Successfully merging this pull request may close these issues.

2 participants