feat: React 19, types, and bumped testing library things #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjordanxd
changed the title
imjordanxd
changed the title
|
You will need to do more changes with the ref typings. See #2612 (comment) |
|
@MiroslavPetrik if we can get a smaller PR that only changes the types, I'd definitely rather go for that! This repo has very little activity these days :/ |
| @@ -9,7 +9,7 @@ export default function usePreviousDistinct<T>( | |||
| value: T, | |||
| compare: Predicate<T> = strictEquals | |||
| ): T | undefined { | |||
| const prevRef = useRef<T>(); | |||
| const prevRef = useRef<T | undefined>(undefined); | |||
There was a problem hiding this comment.
The useRef has 1 required parameter now, but there are still the helper overloads for undefined or null, so you don't need to set those explicitly.
Suggested change
| const prevRef = useRef<T | undefined>(undefined); | |
| const prevRef = useRef<T>(undefined); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps
react,react-dom, andreact-test-rendererto18.3.1. It also bumps the@testing-library/*packages to the latest versions. All changes are either comments, types, internal variables, or test file updates.The types are a bit cooked at the moment - not sure how to address this or how it happened. The types are even broken on
master.Type of change
ensuredForwardRef's render function has a new type,ForwardRefRenderFunction, which may cause breaking changes in consumers.Checklist
yarn test)yarn lint). Fix it withyarn lint:fixin case of failure.yarn lint:types).