clichouse create user query update

streamingfast · Nov 27, 2023 · acf5f3e · acf5f3e
1 parent fad7d61
commit acf5f3e
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/db/dialect_clickhouse.go b/db/dialect_clickhouse.go
@@ -133,22 +133,27 @@ func (d clickhouseDialect) OnlyInserts() bool {
 
 func (d clickhouseDialect) CreateUser(tx Tx, ctx context.Context, l *Loader, username string, password string, _database string, readOnly bool) error {
 	user, pass := EscapeIdentifier(username), EscapeIdentifier(password)
-	var q string
+
+	createUserQ := fmt.Sprintf("CREATE USER %s IDENTIFIED BY '%s';", user, pass)
+	_, err := tx.ExecContext(ctx, createUserQ)
+	if err != nil {
+		return fmt.Errorf("executing query %q: %w", createUserQ, err)
+	}
+
+	var grantQ string
 	if readOnly {
-		q = fmt.Sprintf(`
-            CREATE USER %s IDENTIFIED BY '%s';
+		grantQ = fmt.Sprintf(`
             GRANT SELECT ON *.* TO %s;
-        `, user, pass, user)
+        `, user)
 	} else {
-		q = fmt.Sprintf(`
-            CREATE USER %s IDENTIFIED BY '%s';
+		grantQ = fmt.Sprintf(`
             GRANT ALL ON *.* TO %s;
-        `, user, pass, user)
+        `, user)
 	}
 
-	_, err := tx.ExecContext(ctx, q)
+	_, err = tx.ExecContext(ctx, grantQ)
 	if err != nil {
-		return fmt.Errorf("executing query %q: %w", q, err)
+		return fmt.Errorf("executing query %q: %w", grantQ, err)
 	}
 
 	return nil