Improved error reporting in CLI

streamingfast · Jun 3, 2022 · b10966f · b10966f
1 parent 65b3740
commit b10966f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/cmd/substreams/main.go b/cmd/substreams/main.go
@@ -3,8 +3,6 @@ package main
 import (
 	"fmt"
 	"strings"
-
-	"github.com/streamingfast/derr"
 )
 
 // Commit sha1 value, injected via go build `ldflags` at build time
@@ -19,7 +17,10 @@ var date = ""
 func main() {
 	rootCmd.Version = computeVersionString(version, commit, date)
 	setup()
-	derr.Check("substreams", rootCmd.Execute())
+
+	if err := rootCmd.Execute(); err != nil {
+
+	}
 }
 
 func computeVersionString(version, commit, date string) string {

diff --git a/cmd/substreams/run.go b/cmd/substreams/run.go
@@ -133,8 +133,6 @@ func runRun(cmd *cobra.Command, args []string) error {
 			fmt.Printf("RETURN HANDLER ERROR: %s\n", err)
 		}
 	}
-
-	return nil
 }
 
 func defaultOutputMode(outputMode string) (string, error) {

diff --git a/docs/release-notes/change-log.md b/docs/release-notes/change-log.md
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## Unreleased
 
+### `substreams` CLI
+
+* Do log last error when the CLI exit with an error has the error is already printed to the user and it creates a weird behavior.
+
 ## [v0.0.11](https://github.com/streamingfast/substreams/releases/tag/v0.0.11)
 
 ### `substreams` Docker
-Original file line number
+Diff line change
@@ Expand Up / @@ -133,8 +133,6 @@ func runRun(cmd *cobra.Command, args []string) error { @@
     			fmt.Printf("RETURN HANDLER ERROR: %s\n", err)
     		}
     	}
-    	return nil
     }
     func defaultOutputMode(outputMode string) (string, error) {
@@ Expand Down @@